Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 )
Change subject: java: ColumnSchema supports storing column comment ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12890/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java: http://gerrit.cloudera.org:8080/#/c/12890/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@213 PS1, Line 213: public String getComment() { > Maybe we need a consensus view of comment first: I think Grant is proposing: 1. Logically, a comment must be a non-empty string. 2. Therefore, in our public API "no comment" is modeled as an empty string. 3. Therefore, in our public API there is no such thing as a NULL comment. 4. There are two possible actions a user can take: 4a. Adding a column comment means going from empty string to non-empty string. 4b. Deleting a column comment means going from non-empty string to empty string. 4c. If possible (and if not too challenging), we should try to optimize "no-op" comment changes (i.e. empty string to empty string, or "foo" to "foo") and not send them to the server. I'm OK with this, and I hope it'll let us reduce some of the boost::optional complexity server-side (and C++ client-side). Do you think it'll help reduce complexity? -- To view, visit http://gerrit.cloudera.org:8080/12890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cdca4101898062cfe154c15ca40c5943d0e343c Gerrit-Change-Number: 12890 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Sun, 31 Mar 2019 18:53:09 +0000 Gerrit-HasComments: Yes
