Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12898 )
Change subject: [curl] Fix error status of timeout ...................................................................... Patch Set 4: (2 comments) The test failure looks like KUDU-2059 which is unrelated to your patch. http://gerrit.cloudera.org:8080/#/c/12898/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12898/4//COMMIT_MSG@7 PS4, Line 7: [curl] Fix error status of timeout Curious in what context you found this? A new test? http://gerrit.cloudera.org:8080/#/c/12898/4/src/kudu/util/curl_util-test.cc File src/kudu/util/curl_util-test.cc: http://gerrit.cloudera.org:8080/#/c/12898/4/src/kudu/util/curl_util-test.cc@29 PS4, Line 29: // When using a thread sanitizer, there will be a data race when timeout. Can you share what this data race looks like? -- To view, visit http://gerrit.cloudera.org:8080/12898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fab1bd1a34b06624db4fd51d782a213f93321c Gerrit-Change-Number: 12898 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 31 Mar 2019 18:57:56 +0000 Gerrit-HasComments: Yes
