Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 )
Change subject: sentry: sanitize and parse privileges from Sentry ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12919/3/src/kudu/sentry/sentry_authorizable_scope.h File src/kudu/sentry/sentry_authorizable_scope.h: http://gerrit.cloudera.org:8080/#/c/12919/3/src/kudu/sentry/sentry_authorizable_scope.h@91 PS3, Line 91: AuthorizableScopesSet > Still not sure I understand; different calls to this function shouldn't sha We discussed it offline, but I'm adding this for extra reference. The idea is to have 4 static instances of AuthorizableScopesSet, each pre-populated with initializer list. Each might reside within the corresponding 'case' scope, so it's something like the following for the 'SERVER' scope: ... case SentryAuthorizableScope::SERVER: { static const AuthorizableScopesSet kServerScopes{ SentryAuthorizableScope::DATABASE, SentryAuthorizableScope::TABLE, SentryAuthorizableScope::COLUMN, }; return kServerScopes; } ... -- To view, visit http://gerrit.cloudera.org:8080/12919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6de6814f99abfbee4f030298b74f21f4e7c729b Gerrit-Change-Number: 12919 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 04 Apr 2019 19:53:35 +0000 Gerrit-HasComments: Yes
