Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 )
Change subject: [metrics] Remove incorrect comments ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12921/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12921/1//COMMIT_MSG@10 PS1, Line 10: and it's not needed to sort metrics. > I see how this was previously broken, but don't we want to sort the output? There are dozens of metrics, and dozens of metric entities on a server, it's hard to check any metric even if they are sorted. I think users may prefer to search a certain metric name when they check the raw metrics output. For third-party monitor systems, it doesn't matter whether metrics are sorted or not. This rule seems have been broken for years and nobody complains, it's not a real need in my opinion. http://gerrit.cloudera.org:8080/#/c/12921/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/12921/1/src/kudu/util/metrics.cc@224 PS1, Line 224: InsertOrDie(&metrics, prototype, metric); > With 'metrics' now being a MetricMap, it may be faster to reduce the amount Done -- To view, visit http://gerrit.cloudera.org:8080/12921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 Gerrit-Change-Number: 12921 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 05 Apr 2019 14:44:42 +0000 Gerrit-HasComments: Yes
