Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11752 )
Change subject: authz: authorize ListTablets ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11752/4/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/11752/4/src/kudu/tserver/tablet_service.h@113 PS4, Line 113: Rather than authorizing multiple tables at : // once, if enforcing access control, we require the super-user role and omit : // checking table privileges, and authorize as a client otherwise. > Should we do the same for ListTables in the master? Why or why not? The rationale for why this isn't contentious here is that, as far as Kudu's codebase is concerned, this is used by tools only. Sure, there might be people using the endpoint directly, but that's quite unlikely. This isn't the case for ListTables, which is a part of the public client API. I'd love for us to do this for ListTables, but it seems like a much higher-impact restriction. We could, and maybe that would be good enough. But it's less of a no-brainer IMO. -- To view, visit http://gerrit.cloudera.org:8080/11752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb2d09f23d7b77729e21060dad41c0501b17ded Gerrit-Change-Number: 11752 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 08 Apr 2019 05:53:15 +0000 Gerrit-HasComments: Yes
