Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12907 )
Change subject: remove schema copies from RowBlock and RowBuilder ...................................................................... remove schema copies from RowBlock and RowBuilder AFAICT the schemas in these two always outlive the classes themselves, so there's no reason to make schema copies. This is especially painful for the MergeIterator where each sub-iterator has a RowBlock (and thus a full copy of the schema). Change-Id: Ie4d60640b2bac4f2b3077ddd696966e1f6658740 Reviewed-on: http://gerrit.cloudera.org:8080/12907 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> --- M src/kudu/codegen/codegen-test.cc M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/row.h M src/kudu/common/row_changelist-test.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h M src/kudu/common/schema-test.cc M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-pushdown-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 31 files changed, 178 insertions(+), 143 deletions(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie4d60640b2bac4f2b3077ddd696966e1f6658740 Gerrit-Change-Number: 12907 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]>
