Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12981/2/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/12981/2/src/kudu/tools/tool_action.cc@388 PS2, Line 388: gflag_info.default_value); Should probably escape this too, since the default value for a string can have arbitrary characters in it, including HTML. -- To view, visit http://gerrit.cloudera.org:8080/12981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713 Gerrit-Change-Number: 12981 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 10 Apr 2019 17:01:50 +0000 Gerrit-HasComments: Yes