Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12947 )
Change subject: KUDU-2466: implement three-heap merge algorithm ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/12947/7/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12947/7/src/kudu/common/generic_iterators.cc@148 PS7, Line 148: Status Init(Arena* decoded_bounds_arena) { > It looks like this also fixes KUDU-2466, right? If so, maybe that should be Oh yeah, I suppose it should. http://gerrit.cloudera.org:8080/#/c/12947/7/src/kudu/common/generic_iterators.cc@217 PS7, Line 217: > nit: add /*nrows=*/ Done http://gerrit.cloudera.org:8080/#/c/12947/7/src/kudu/common/generic_iterators.cc@420 PS7, Line 420: COLD to HOT > I think this should be from COLD to HOT. https://www.snopes.com/fact-check/brown-out/ (done) http://gerrit.cloudera.org:8080/#/c/12947/7/src/kudu/common/generic_iterators.cc@739 PS7, Line 739: ++iter > nit: ++iter for complex objects like iterators so the previous iterator sta Done -- To view, visit http://gerrit.cloudera.org:8080/12947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6deab76a103f45c1b5042b104731e46a771a0f5d Gerrit-Change-Number: 12947 Gerrit-PatchSet: 9 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 13 Apr 2019 04:22:29 +0000 Gerrit-HasComments: Yes
