Hello Andrew Wong, helifu, Hao Hao, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13021 to review the following change. Change subject: log_block_manager: reenable dead container deletion at runtime ...................................................................... log_block_manager: reenable dead container deletion at runtime A quick timeline: 1. The feature was added and its behavior enabled. 2. Occasionally, block_manager-stress-test would SIGSEGV [1]. These failures showed up in the flaky test dashboard. 3. So, a feature flag was added in commit 8dc7904. The flag was false by default, only set to true for a handful of tests. 4. In commit 3e0fcc9, the flag was set to true in block_manager-stress-test so that we could continue to debug the issue. 5. Except that it hasn't surfaced since then; the last block_manager-stress-test failure was on 02/03/19. It's a mystery as to why there haven't been any block_manager-stress-test failures since #4. Maybe something isn't working quite right with the feature flag, or maybe the failure was due to something else. Either way, let's try to enable the feature again, since it's still early in the 1.10 release cycle. 1. http://dist-test.cloudera.org:8080/download_log?c195c2b0-2845-11e9-a3f1-0242ac110002 Change-Id: Icd8742c150e1447e7838d9f86173536b5726cd40 --- M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc 3 files changed, 1 insertion(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/13021/1 -- To view, visit http://gerrit.cloudera.org:8080/13021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icd8742c150e1447e7838d9f86173536b5726cd40 Gerrit-Change-Number: 13021 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com>