Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13010 )
Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization ...................................................................... generic_iterators: refactor MergeIterator for whole-block-copy optimization This patch refactors MergeIterator::MaterializeBlock in preparation for the whole-block-copy optimization. Specifically, the "copy next row" and "advance iter and rebalance heaps" operations have been decomposed into standalone functions so that it'll be easier to add "copy whole block" as an equivalent function in the future. Also of note: we no longer set the entire client selection vector up front, as this won't necessarily be the case when we copy a block. Change-Id: I050116edc51bb3e91852e6286c221175770e6382 Reviewed-on: http://gerrit.cloudera.org:8080/13010 Reviewed-by: Mike Percy <mpe...@apache.org> Tested-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/common/generic_iterators.cc 1 file changed, 135 insertions(+), 130 deletions(-) Approvals: Mike Percy: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/13010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I050116edc51bb3e91852e6286c221175770e6382 Gerrit-Change-Number: 13010 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
