Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 )
Change subject: master: use AuthzProvider to generate authz tokens ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13013/4/src/kudu/util/random_util.h File src/kudu/util/random_util.h: http://gerrit.cloudera.org:8080/#/c/13013/4/src/kudu/util/random_util.h@59 PS4, Line 59: 1 + c.size() - min_to_re > Ah you're right that short-circuiting isn't necessary -- we can just pass i Ah whoops, that +1 is indeed important. -- To view, visit http://gerrit.cloudera.org:8080/13013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5404d6437699bc6c7c8bb0e530b202109e8f166 Gerrit-Change-Number: 13013 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 19 Apr 2019 15:52:31 +0000 Gerrit-HasComments: Yes
