Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13109 )
Change subject: [test] Add testOpenScanWithDroppedPartition test ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13109/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/13109/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@182 PS1, Line 182: ta > a Done http://gerrit.cloudera.org:8080/#/c/13109/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@182 PS1, Line 182: ta > Missed this? Done http://gerrit.cloudera.org:8080/#/c/13109/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/13109/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@216 PS2, Line 216: // Give time for the background drop operations. : Thread.sleep(1000); > Will this be enough time for ASAN/TSAN builds? I think so, we can always bump it. On my laptop it takes 40 milliseconds to fully delete the tablet. http://gerrit.cloudera.org:8080/#/c/13109/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@223 PS2, Line 223: assertTrue(capture.getAppendedText().contains("Deleting tablet data")); : assertTrue(capture.getAppendedText().contains("successfully deleted")); > These are from the cluster itself? Very clever. Yes, the cluster logs also go to the root logger which the CapturingLogAppender attaches to. -- To view, visit http://gerrit.cloudera.org:8080/13109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7538260aff7439fa9a5534d680cd2c2b60006549 Gerrit-Change-Number: 13109 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 25 Apr 2019 13:11:55 +0000 Gerrit-HasComments: Yes
