Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13112 )
Change subject: [ttl_cache] allow outstanding handles ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13112/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13112/1//COMMIT_MSG@9 PS1, Line 9: This patch improves TTLCache so that it's safe to keep a handle to : an entry in the cache even if the cache itself has already gone. > From the other side, adding shared pointers here and there has their costs. Frankly, I'm finding the ownership semantics difficult to follow due to the number of layers (the sharded cache, the TTL cache, the cache handles, the TTL cache's handles), so anything that simplifies ownership is a win in my book. And I'd definitely vote against added flexibility if there's no use case for it. You can doc the possibilities should it come up in the future. -- To view, visit http://gerrit.cloudera.org:8080/13112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I280884a630985c5783b7f99f992f530b5f4b9d50 Gerrit-Change-Number: 13112 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Apr 2019 17:05:08 +0000 Gerrit-HasComments: Yes
