Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13120 )
Change subject: KUDU-2790: Enhance the backup and restore tests ...................................................................... Patch Set 2: (2 comments) I didn't review the new tests super closely but the rest looks fine. http://gerrit.cloudera.org:8080/#/c/13120/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13120/2//COMMIT_MSG@13 PS2, Line 13: Along with improvments to existing test the following improvements http://gerrit.cloudera.org:8080/#/c/13120/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/13120/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@48 PS2, Line 48: // Verify there is a table to backup. : if (!context.syncClient.tableExists(tableName)) { : throw new RuntimeException(s"Table does not exist: $tableName") : } Won't openTable() already do this? -- To view, visit http://gerrit.cloudera.org:8080/13120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7300469887656d3f995ef063e915ca7255fbf0bb Gerrit-Change-Number: 13120 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 25 Apr 2019 20:01:14 +0000 Gerrit-HasComments: Yes
