Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13121 )
Change subject: [backup] Remove suffix default of “-restore” ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13121/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13121/2//COMMIT_MSG@11 PS2, Line 11: be an empyt string. > empty Done http://gerrit.cloudera.org:8080/#/c/13121/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala: http://gerrit.cloudera.org:8080/#/c/13121/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala@199 PS2, Line 199: "true.") > Maybe "Default to no suffix" or some such? Or is that obvious? Done http://gerrit.cloudera.org:8080/#/c/13121/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala@199 PS2, Line 199: "true.") > Yeah, I sort of assumed it was obvious. I could add "no suffix if not set" Done -- To view, visit http://gerrit.cloudera.org:8080/13121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5afd092e3e0c7d27d4b2b3881f24f55884845595 Gerrit-Change-Number: 13121 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 25 Apr 2019 20:16:46 +0000 Gerrit-HasComments: Yes
