Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 )
Change subject: [master] add RPC to reset AuthzProvider's cache ...................................................................... Patch Set 5: Code-Review+1 (6 comments) Just few nits. http://gerrit.cloudera.org:8080/#/c/13063/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13063/5//COMMIT_MSG@9 PS5, Line 9: RPC Mention it can only used by super user? http://gerrit.cloudera.org:8080/#/c/13063/5//COMMIT_MSG@9 PS5, Line 9: control SentryAuthzProvider's : privileges cache nit: maybe mention this is specific to clear the privilege cache. http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc@200 PS5, Line 200: client_->DeleteTable(table) nit: use DropTable below instead? http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc@203 PS5, Line 203: DropTable nit: is this used somewhere? can DeleteTable be used instead? It is a bit weird to have one method named DropTable and the other as DeleteTable which calls the same thing under the hood. http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc@759 PS5, Line 759: AlterTable (I know you mentioned but) maybe add a TODO for all other DDLs like CreateTable/RenameTable/DropTable for the same kind of test. Also for Concurrent test below. http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/master/sentry_privileges_fetcher.cc File src/kudu/master/sentry_privileges_fetcher.cc: http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/master/sentry_privileges_fetcher.cc@450 PS5, Line 450: VLOG(1) Why remove VLOG_IS_ON? -- To view, visit http://gerrit.cloudera.org:8080/13063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a5c1f84172acf5751f68edfb8a9bb25df6b3f6 Gerrit-Change-Number: 13063 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Comment-Date: Fri, 26 Apr 2019 00:56:32 +0000 Gerrit-HasComments: Yes
