Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13258 )
Change subject: docs: added contributing section for new third-party dependencies ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/13258/1/docs/contributing.adoc File docs/contributing.adoc: http://gerrit.cloudera.org:8080/#/c/13258/1/docs/contributing.adoc@499 PS1, Line 499: . Test the Kudu build using the new dependency. You may need to pass Maybe remove "may". I think passing NO_REBUILD_THIRDPARTY is required unless they add a patchlevel-n file to the dependencies src directory. -- To view, visit http://gerrit.cloudera.org:8080/13258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5c8e0feaead7252c0e66ae4aeacac4932be1a10 Gerrit-Change-Number: 13258 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 13:42:23 +0000 Gerrit-HasComments: Yes
