Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13263 )
Change subject: KUDU-2775: Deflake DefaultSourceTest repartition tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13263/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/13263/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@472 PS1, Line 472: // Make sure the job is complete. > So insertRows() isn't synchronous? That is, it can return and the job may s It appears the SparkListener.onTaskEnd isn't synchronous and `assertEquals(4, actualNumTasks)` could be called after a task ends but before the counter is updated. We do have one other location this could happen in DistributedDataGeneratorTest. I will update there too. http://gerrit.cloudera.org:8080/#/c/13263/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@476 PS1, Line 476: 5000 > Is this a timeout? Can you loop with TSAN and make sure it's high enough? This should be drastically more than enough and the environment shouldn't matter since it would be waiting on Java side things only. -- To view, visit http://gerrit.cloudera.org:8080/13263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2302170df3bf3ebac6cc06381d764419c2d48303 Gerrit-Change-Number: 13263 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2019 19:58:50 +0000 Gerrit-HasComments: Yes
