Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13274 )
Change subject: [master_path_handlers] fix build on macOS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13274/2/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/13274/2/src/kudu/master/master_path_handlers.cc@331 PS2, Line 331: (*output)["column_count"] = static_cast<int64_t>(schema.num_columns()); > I suppose we ought to put a note here about why we're doing this random cas I addressed that in https://gerrit.cloudera.org/#/c/13281/ Please take a look. -- To view, visit http://gerrit.cloudera.org:8080/13274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271 Gerrit-Change-Number: 13274 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 07:40:28 +0000 Gerrit-HasComments: Yes
