Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13265 )
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG@12 PS1, Line 12: Raising the default will cause clients to be able to scan further into : the past before, into a region where the data has been GC'd. > What happens if you try to scan into this region? Done http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG@14 PS1, Line 14: condition will be temporarily, and will end when the new default period > temporary Done http://gerrit.cloudera.org:8080/#/c/13265/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13265/1/src/kudu/tablet/tablet.cc@137 PS1, Line 137: DEFINE_int32(tablet_history_max_age_sec, 60 * 60 * 24 * 7, > Should probably also stabilize this flag if we expect configuration managem Done -- To view, visit http://gerrit.cloudera.org:8080/13265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb Gerrit-Change-Number: 13265 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 19:34:37 +0000 Gerrit-HasComments: Yes
