Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13294 )
Change subject: [util] Introduce yaml-cpp to read config files ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/13294/5/cmake_modules/FindYaml.cmake File cmake_modules/FindYaml.cmake: http://gerrit.cloudera.org:8080/#/c/13294/5/cmake_modules/FindYaml.cmake@22 PS5, Line 22: find_library(YAML_STATIC_LIB libyaml-cpp.a > Could we also generate a shared library version of yaml-cpp to use for dyna yaml-cpp does not support build both shared and static libraries concurrently, and I'm confused when to use dynamically link in kudu? http://gerrit.cloudera.org:8080/#/c/13294/5/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13294/5/thirdparty/build-definitions.sh@928 PS5, Line 928: CFLAGS="$EXTRA_CFLAGS -fPIC" \ : CXXFLAGS="$EXTRA_CXXFLAGS -fPIC" \ > Done Link error occured if not. Errors like: 03:16:50 [ 30%] Linking CXX shared library ../../../lib/libkudu_util.so 03:16:50 /usr/bin/ld: ../../../../../thirdparty/installed/uninstrumented/lib/libyaml-cpp.a(exceptions.cpp.o): relocation R_X86_64_32S against `_ZTVN4YAML9ExceptionE' can not be used when making a shared object; recompile with -fPIC 03:16:50 ../../../../../thirdparty/installed/uninstrumented/lib/libyaml-cpp.a: error adding symbols: Bad value -- To view, visit http://gerrit.cloudera.org:8080/13294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ef58befaffbcc880e13fa6fec61b8e94a189b5a Gerrit-Change-Number: 13294 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 11:10:15 +0000 Gerrit-HasComments: Yes
