Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13304 )
Change subject: [java] Upgrade to log4j 2 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13304/4/java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java: http://gerrit.cloudera.org:8080/#/c/13304/4/java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java@40 PS4, Line 40: private static final PatternLayout LAYOUT = PatternLayout.newBuilder() It turns out MessageLayout doesn't work like I expected. It doesn't substitute logging {} arguments. I changed this to use the same PatternLayout as the file appender. I think this makes sense given this is the same layout we define in the test log4j properties files. -- To view, visit http://gerrit.cloudera.org:8080/13304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e14a3a25c36d5f47d07f06c1c0e68dad42bc66 Gerrit-Change-Number: 13304 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 May 2019 13:40:28 +0000 Gerrit-HasComments: Yes
