Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13373 )
Change subject: [tool] update type of loadgen's --num_rows_per_thread flag ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13373/2/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/13373/2/src/kudu/tools/tool_action_perf.cc@437 PS2, Line 437: CHECK_LT(0, FLAGS_num_threads); Probably more intuitive to do this in a gflag validator. -- To view, visit http://gerrit.cloudera.org:8080/13373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2712ac7678c9cfd9359629f11df3a86dd727997d Gerrit-Change-Number: 13373 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 20 May 2019 03:39:07 +0000 Gerrit-HasComments: Yes
