Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13317 )
Change subject: Allow alter legacy tables in Hive Metastore Kudu plugin ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13317/5/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13317/5/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@258 PS5, Line 258: // Check that altering table with Kudu storage handler to legacy format : // succeeds. : { : Table alteredTable = table.deepCopy(); : alteredTable.getParameters().clear(); : alteredTable.putToParameters(hive_metastoreConstants.META_TABLE_STORAGE, : KuduMetastorePlugin.LEGACY_KUDU_STORAGE_HANDLER); : alteredTable.putToParameters(KuduMetastorePlugin.LEGACY_KUDU_TABLE_NAME, : "legacy_table"); : alteredTable.putToParameters(KuduMetastorePlugin.KUDU_MASTER_ADDRS_KEY, : "localhost"); : client.alter_table(table.getDbName(), table.getTableName(), alteredTable); : } > In the case a user needs to downgrade to <Impala 3.3 they will also need to I don't think we actually need to address it here. The main motivation of this patch is to allow altering legacy tables (without downgrade or upgrade) when the plugin is used. If we decide we don't want to support downgrade with the plugin enabled, we can do it in a follow up change. -- To view, visit http://gerrit.cloudera.org:8080/13317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie76ce2cd7dda0b4391e91abe2da2801d305a64d3 Gerrit-Change-Number: 13317 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 May 2019 06:40:53 +0000 Gerrit-HasComments: Yes
