Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13401 )
Change subject: KUDU-2802 [java] tableExists API optimizations ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13401/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/13401/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@845 PS1, Line 845: if (e instanceof NonRecoverableException) { FWIW, I think this may be guaranteed. That is, by the time we've called this errback, any recoverable exceptions have likely been retried. If we make it here, it's because we got an error we couldn't recover from, or we timed out while retrying a recoverable error. But this is more defensive, so let's keep it the way it is. -- To view, visit http://gerrit.cloudera.org:8080/13401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7076aea3850a716822563938d879289beb3fa67c Gerrit-Change-Number: 13401 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 16:55:06 +0000 Gerrit-HasComments: Yes
