Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13418

to review the following change.


Change subject: java: fix CapturingToFileLogAppender
......................................................................

java: fix CapturingToFileLogAppender

It was broken in commit 0114ce1d0: the try-with-resources in the constructor
closed the OutputStream out from under the BufferedWriter.

I added a regression test for this.

Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
---
M 
java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M 
java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
A 
java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
3 files changed, 174 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/13418/1
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>

Reply via email to