Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13384 )

Change subject: hms: fix flakiness of master-stress-test from managed tables
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13384/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13384/2//COMMIT_MSG@9
PS2, Line 9:  managed tables opened the door
I think this can happen without the switch? Switching only means it increase 
the risk of such failure?


http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc
File src/kudu/integration-tests/master-stress-test.cc:

http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc@280
PS1, Line 280:           MatchPattern(s.ToString(), "*FileNotFoundException*")) 
{
             :         // Check that the table was not created in Kudu.
             :         client::sp::shared_ptr<KuduTable> table;
             :         s = client_->OpenTable(to_create, &table);
             :         CHECK(s.IsNotFound()) << s.ToString();
             :
             :         // Check that the table was not created in the HMS.
             :         Slice db;
             :         Slice table_name;
             :         CHECK_OK(ParseHiveTableIdentifier(to_create, &db, 
&table_name));
             :         hive::Table hms_table;
             :         Status s = hms_client_->GetTable(db.To
> If the table hasn't been rolled back, the new leader will see an AlreadyPre
Have you ever saw master-stress-test failed with such error? If so, should we 
also account for such failure?



--
To view, visit http://gerrit.cloudera.org:8080/13384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1233e5b133035d36f98ce08265c0273570caa454
Gerrit-Change-Number: 13384
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 00:47:14 +0000
Gerrit-HasComments: Yes

Reply via email to