Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13431
to review the following change.
Change subject: java: fix errorprone warnings
......................................................................
java: fix errorprone warnings
kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java:85:
warning: [EqualsGetClass] Overriding Object#equals in a non-final class by
using getClass rather than instanceof breaks substitutability of subclasses.
public boolean equals(Object o) {
^
kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:118:
warning: [UnusedVariable] The field 'PERCENTAGE_RANGE' is never read.
private static final Range<Float> PERCENTAGE_RANGE = Range.closed(0.0f, 1.0f);
^
(see https://errorprone.info/bugpattern/UnusedVariable)
Did you mean to remove this line or 'static { Range.closed(0.0f, 1.0f); }'?
Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/13431/1
--
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
