helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13376 )
Change subject: [util] Support for entity type/id/attrs/metrics filtering in metrics ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/13376/6//COMMIT_MSG Commit Message: PS6: > This should be updated to reflect the "type" -> "types" and "id" -> "ids" ah, i forgot to update it. http://gerrit.cloudera.org:8080/#/c/13376/6/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/13376/6/src/kudu/server/default_path_handlers.cc@327 PS6, Line 327: bool* value > It'd be easier to just return this. Done http://gerrit.cloudera.org:8080/#/c/13376/6/src/kudu/server/default_path_handlers.cc@333 PS6, Line 333: vector<string>* value > Likewise, it'd be easier to just return this. Done http://gerrit.cloudera.org:8080/#/c/13376/5/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13376/5/src/kudu/util/metrics.h@446 PS5, Line 446: // Whether to compact the json result. : bool compact; > I see. I don't think that makes sense: the options here are for callers to Done -- To view, visit http://gerrit.cloudera.org:8080/13376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ca55bd1f0f3d4107cb208f6f855d24121823ee Gerrit-Change-Number: 13376 Gerrit-PatchSet: 6 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Sat, 25 May 2019 07:36:51 +0000 Gerrit-HasComments: Yes
