Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13405 )
Change subject: [backup] Add a tool to clean up old backups ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13405/3/java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala File java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala: http://gerrit.cloudera.org:8080/#/c/13405/3/java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala@108 PS3, Line 108: // from last to first in the path ensures that if the tool crashes partway through then a > this breaks the options.tables.isEmpty case Oops. It actually broke everything. I did things another way, but again it's very temporary given upcoming patches. http://gerrit.cloudera.org:8080/#/c/13405/2/java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala File java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala: http://gerrit.cloudera.org:8080/#/c/13405/2/java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala@118 PS2, Line 118: // Finally, add a third path which is not the restore path but which has backups that are old > That's a good point. Now that we have CLI tools, it seems like we should ch Naming etc is a bit yikes, TBH. The table name situation is also tough. Getting all graphs by names gets all graphs where some name in the graph matches instead of the latest name. Might be good to fix that so it returns only graphs for tables matching latest name. I will do that as part of the patterns patch. -- To view, visit http://gerrit.cloudera.org:8080/13405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a4c4dde10ec3c3c9b2233ee2f7b13c46e963e39 Gerrit-Change-Number: 13405 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 18:13:45 +0000 Gerrit-HasComments: Yes
