Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13460 )
Change subject: [java] Improve TestAsyncKuduSession: Refactor into more tests ...................................................................... [java] Improve TestAsyncKuduSession: Refactor into more tests TestAsyncKuduSession had a few tests, but one of them, ominously called `test`, was actually 7-8 tests in one, with each test shackled to the next by the shared state of the underlying table. The main improvement of this commit is to refactor mega-`test` into several targeted tests. There were some parts of the original mega test method for which I couldn't determine what precisely they were testing. Those parts have been dropped. I also made a few other small improvements which allowed me to drop almost all the helper code in favor of generic test utils. Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009 Reviewed-on: http://gerrit.cloudera.org:8080/13460 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java 1 file changed, 150 insertions(+), 291 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009 Gerrit-Change-Number: 13460 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]>
