Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13461 )
Change subject: [java] Deflake TestAuthTokenReacquire.testBasicMasterOperations ...................................................................... [java] Deflake TestAuthTokenReacquire.testBasicMasterOperations This test was flaky because DDL operations aren't exactly-once (KUDU-1527). The following could happen with table creation or deletion: 1. Thread A issues a CreateTable request for Table A. 2. The master receives the CreateTable request and gets to work creating Table A but has not responded to Thread A yet. 3. Thread B calls `dropConnectionsAndExpireTokens`, dropping connections to the master. 4. Thread A retries the CreateTable RPC, thinking it has failed because the connection was dropped. 5. The master responds with an error because the table exists. This works around the problem by catching and ignoring exceptions indicating that the table already exists in the case of table creation and catching and ignoring exceptions that the table is deleted or does not exist in the case of table deletion. Before this patch, I saw 16/100 runs fail in dist-test against TSAN binaries. With this patch, I saw 0/100 failures. Change-Id: Ifef0a254c6eb1cadeb54e9cef52f78c7ccc7b9c5 Reviewed-on: http://gerrit.cloudera.org:8080/13461 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifef0a254c6eb1cadeb54e9cef52f78c7ccc7b9c5 Gerrit-Change-Number: 13461 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]>
