Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13484
to review the following change.
Change subject: external_mini_cluster: bump start process timeout a bit more
......................................................................
external_mini_cluster: bump start process timeout a bit more
Commit 08b916d4b did help reduce the occurrence of NTP desynchronization in
tests, but not completely. Worse, tests that now do time out do so in a way that
doesn't blame NTP at all. For example:
Bad status: Timed out: failed to start masters: Unable to start Master
at index 0: Timed out after 60.000s waiting for process (...) to write
info file (...)
This also affects test result reporting, which tries to avoid reporting test
runs where NTP failed to synchronize by searching for the "Clock considered
unsynchronized" magic string. Of course, that won't happen if the minicluster,
thinking that its subprocesses timed out, kills them before they fail that way.
Here's a dumb fix: let's increase the start process timeout a bit. That gives
the servers more time with which to reach the NTP desynchronization timeout.
Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13484/1
--
To view, visit http://gerrit.cloudera.org:8080/13484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95de5368298b9c7fd1ea0b7166dd6c3cd24e356b
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
