Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_descriptor-test.cc File src/kudu/master/ts_descriptor-test.cc: http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_descriptor-test.cc@37 PS3, Line 37: using std::vector; > warning: using decl 'vector' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_descriptor-test.cc@38 PS3, Line 38: using strings::Substitute; > warning: using decl 'Substitute' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_manager.cc@153 PS3, Line 153: instance, registration, location, std::move(dns_resolver))); > warning: std::move of the variable 'dns_resolver' of the trivially-copyable Done http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_manager.cc@156 PS3, Line 156: instance, registration, location, std::move(dns_resolver), &descriptor)); > warning: std::move of the variable 'dns_resolver' of the trivially-copyable Done -- To view, visit http://gerrit.cloudera.org:8080/13469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc Gerrit-Change-Number: 13469 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 02 Jun 2019 15:51:21 +0000 Gerrit-HasComments: Yes
