Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13493 )
Change subject: sentry: add trace points ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13493/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13493/1//COMMIT_MSG@10 PS1, Line 10: found useful Can you briefly describe why you found adding traces in these places is useful? http://gerrit.cloudera.org:8080/#/c/13493/1/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/13493/1/src/kudu/master/sentry_authz_provider.cc@77 PS1, Line 77: TRACE("Evaluating privileges"); Do you think we need trace for authorizing each DDLs? -- To view, visit http://gerrit.cloudera.org:8080/13493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ed344aa38437faf4d6cfa9640cad443f38f6bd8 Gerrit-Change-Number: 13493 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 03 Jun 2019 04:17:01 +0000 Gerrit-HasComments: Yes
