Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13509 )
Change subject: KUDU-2830: [java] Improve RPC traces on RPC timeout ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13509/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: http://gerrit.cloudera.org:8080/#/c/13509/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java@403 PS1, Line 403: buf.append(", deferred=").append(deferred); Is this intentionally omitted from 'buf' in the other branch? http://gerrit.cloudera.org:8080/#/c/13509/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java: http://gerrit.cloudera.org:8080/#/c/13509/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java@187 PS1, Line 187: UNKOWN UNKNOWN here and below. http://gerrit.cloudera.org:8080/#/c/13509/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java@213 PS1, Line 213: authWaitCount I think 'authTokenRefresh' or 'authRefresh' is better. What do you think? http://gerrit.cloudera.org:8080/#/c/13509/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java@222 PS1, Line 222: StringBuilder sb = new StringBuilder(); I wish there were a better alternative to this StringBuilder nonsense, something like what's possible with strings::Substitute and multiline literals in C++, or with the s"$foo" feature in Scala. Obviously no defects vs. no obvious defects. -- To view, visit http://gerrit.cloudera.org:8080/13509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I725e3e8f89f5a433a0ffcb4b0facf82d9ffc4840 Gerrit-Change-Number: 13509 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 04 Jun 2019 15:15:16 +0000 Gerrit-HasComments: Yes
