Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13516 )
Change subject: Add seek before mode for CBTree to accelerate CheckRowDeleted in dms. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13516/1/src/kudu/tablet/concurrent_btree.h File src/kudu/tablet/concurrent_btree.h: http://gerrit.cloudera.org:8080/#/c/13516/1/src/kudu/tablet/concurrent_btree.h@1755 PS1, Line 1755: LOG(FATAL) << "unknown seek mode."; > My preference here would be to do have no 'default' case, so that > we don't generate unreachable code and bloat the relatively hot > path +1, maybe we can write like this: if (mode == AT_OR_BEFORE) { ... } else { DCHECK_EQ(mode, AT_OR_AFTER); ... } -- To view, visit http://gerrit.cloudera.org:8080/13516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icda5585c7226a075ffebdb22c7fc7728edf85feb Gerrit-Change-Number: 13516 Gerrit-PatchSet: 1 Gerrit-Owner: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: ZhangYao <triplesheep0...@gmail.com> Gerrit-Comment-Date: Thu, 06 Jun 2019 04:19:53 +0000 Gerrit-HasComments: Yes
