Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13511 )
Change subject: KUDU-2785: Add splitSizeBytes to the backup job ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13511/4/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/13511/4/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@346 PS4, Line 346: // Wait for mrs flushed. : Thread.sleep(5 * 1000) > Why? This matches the pattern for all of the other split size unit tests. It makes sure there is no flakiness due to slow flushing. http://gerrit.cloudera.org:8080/#/c/13511/4/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@356 PS4, Line 356: task > nit: tasks Done -- To view, visit http://gerrit.cloudera.org:8080/13511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6b8d02b71b1f463e4d0d9e04203d8edbd5e016b Gerrit-Change-Number: 13511 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 06 Jun 2019 20:20:37 +0000 Gerrit-HasComments: Yes
