Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13341 )
Change subject: Support SPNEGO for web server ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13341/3/src/kudu/security/gssapi.cc File src/kudu/security/gssapi.cc: http://gerrit.cloudera.org:8080/#/c/13341/3/src/kudu/security/gssapi.cc@144 PS3, Line 144: *complete = s.ok(); > interesting. The manpage indicates it does need to be freed. Not sure why L Added by yours truly: // KUDU-2653: Memory leak in libgssapi_krb5 [1]. Exists in certain patched // versions of krb5-1.12 (such as krb5 in Debian 8). // // Unfortunately there's no narrower match without resorting to // fast_unwind_on_malloc=0; the best alternative is to match on glob, but that // seems like overkill too. // // 1. http://krbdev.mit.edu/rt/Ticket/Display.html?id=7981 "leak:libgssapi_krb5.so.2\n"; -- To view, visit http://gerrit.cloudera.org:8080/13341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9449ac610aa7d11bbf320d9178a6d73684ff15f7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 07 Jun 2019 05:27:08 +0000 Gerrit-HasComments: Yes