Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 )
Change subject: [c++] Support table rename between scan token creation and rehydration ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.h@144 PS2, Line 144: enum class TableIdentifierType { > Maybe just pass the TableIdentifierPB into these functions directly? They'r Done http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.h@151 PS2, Line 151: Status OpenTable(KuduClient* client, > warning: function 'kudu::client::KuduClient::Data::OpenTable' has a definit Done http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.h@152 PS2, Line 152: identifer > ah, it's complaining about a typo here: should be indentifier_type Done http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.h@169 PS2, Line 169: Status GetTableSchema(KuduClient* client, : const std::string& table_name, : const MonoTime& deadline, : KuduSchema* schema, : PartitionSchema* partition_schema, : std::string* table_id, : int* num_replicas); > Can we eliminate this variant? Seems like it's only used in one or two plac Done http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/13521/2/src/kudu/client/client-internal.cc@563 PS2, Line 563: nullptr > nit: /*table_name=*/nullptr <code deleted> -- To view, visit http://gerrit.cloudera.org:8080/13521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d48513dff67012f26a99877b168d777d3049fd Gerrit-Change-Number: 13521 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 07 Jun 2019 17:56:28 +0000 Gerrit-HasComments: Yes
