Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@311 PS7, Line 311: DELETEs won't be found in the results > I don't see an easy way to do that without rewriting the entire test. Can y It would seem fine to me to simply copy / paste the setup part of the test (schema / table creation) and then insert a row, get start timestamp, delete a row, get end timestamp, diff scan(start, end) returns a single deleted row. It would be a pretty short unit test and maintain Java client coverage of IS_DELETED. -- To view, visit http://gerrit.cloudera.org:8080/13538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed Gerrit-Change-Number: 13538 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2019 22:20:19 +0000 Gerrit-HasComments: Yes
