Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13566 )
Change subject: authz: refactor authorization for ListTables ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/catalog_manager.cc@2843 PS4, Line 2843: // Finally, fill the response with the table IDs and names that were : // authorized. How about just doing this on L2833/L2838 instead of intermediating through yet another collection? http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/sentry_authz_provider.cc@197 PS4, Line 197: *checked_table_names = true; If table_names was empty, should this still be true? -- To view, visit http://gerrit.cloudera.org:8080/13566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568e1be7b909768a99f0f4f13775e34a01ccd160 Gerrit-Change-Number: 13566 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jun 2019 04:18:15 +0000 Gerrit-HasComments: Yes
