Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart ...................................................................... Patch Set 4: (3 comments) I'm thinking of adding more unit and integration testing for helm chart in new commit, but all resource's regarding testing point to Go-Lang. do we have any best practice for Go Lang? http://gerrit.cloudera.org:8080/#/c/13568/4/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/13568/4/docker/kudu-entrypoint.sh@80 PS4, Line 80: sleep 2; > Curious about this change. Was 1 second not enough in some cases? Are we su we using podManagementPolicy: "Parallel" which should take care of launching all pods at the same time, but for more than 5 kudu masters, I saw a second delay by then kudu throws an error with "host not reachable" 2 seconds worked for 20 kudu masters pods http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/README.adoc File kubernetes/helm/README.adoc: PS4: > Does this readme need to be separate? Could it be merged with the readme o I felt it's good to have a sperate readme file's, one readme with all the steps would confuse viewers. as we can keep adding more related to the helm in its readme file, like testing, upgrade scenarios, etc.. http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml File kubernetes/helm/kudu/Chart.yaml: http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml@23 PS4, Line 23: version: latest > How should this version be set going forward? I think we should use "latest" always -- To view, visit http://gerrit.cloudera.org:8080/13568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6 Gerrit-Change-Number: 13568 Gerrit-PatchSet: 4 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2019 17:37:40 +0000 Gerrit-HasComments: Yes
