Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13575 )

Change subject: [itbll] make error/failure easier to detect
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13575/3/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
File 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala:

http://gerrit.cloudera.org:8080/#/c/13575/3/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala@86
PS3, Line 86:     System.err.println(s"FAILURE: $msg")
> Just realized, if you still find this to be insufficient, may help to use L
That sounds like a good idea.  I needed a simple pattern to search for 
failures, if any.  That 'FAILURE' prefix seems to be good enough.  However, 
LOG.error() might be better in the sense that it allows for better control over 
the format of the output.

I think I can publish a follow-up changelist to address this,s thanks!



--
To view, visit http://gerrit.cloudera.org:8080/13575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief639a1c075df4f7e6ea9253817345a023e37636
Gerrit-Change-Number: 13575
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Jun 2019 00:30:45 +0000
Gerrit-HasComments: Yes

Reply via email to