Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 )
Change subject: [java] Add “default” database to ITBLL ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13588/1/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java File java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java: http://gerrit.cloudera.org:8080/#/c/13588/1/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java@48 PS1, Line 48: IntegrationTestBigLinkedListHeads > Not that I have seen fail. I think it might be nice to handle the default d I'm surprised it doesn't fail given this code snippet in kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java: private void createTables(int numTablets) throws Exception { createSchema(getTableName(getConf()), getTableSchema(), numTablets); createSchema(getHeadsTable(getConf()), getHeadsTableSchema(), numTablets); } -- To view, visit http://gerrit.cloudera.org:8080/13588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d9da9b6d3616b3fc7713d18f1aae202ffca23e4 Gerrit-Change-Number: 13588 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2019 00:00:58 +0000 Gerrit-HasComments: Yes
