Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13591 )
Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives ...................................................................... Patch Set 3: (3 comments) Code looks fine but the tests seem angry. http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate-test.cc@1538 PS3, Line 1538: num_ret += selvec.CountSelected(); Should probably check the final value of num_ret. http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate.cc@654 PS3, Line 654: return 0x8040201008040201 * t >> 56; :exploding_head: http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate.cc@686 PS3, Line 686: return n_chunks * 8; nit: Could you doc the return value? -- To view, visit http://gerrit.cloudera.org:8080/13591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dd062961a3cd2c892997d6aba12684e603628a1 Gerrit-Change-Number: 13591 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2019 02:36:22 +0000 Gerrit-HasComments: Yes
