Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 )
Change subject: [metrics] Merge metrics by the same attribute ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13580/3/src/kudu/util/metrics.h File src/kudu/util/metrics.h: PS3: > OK, I'll do that Firstly, I'll add the merging functionality in this patch. http://gerrit.cloudera.org:8080/#/c/13580/3/src/kudu/util/metrics.h@436 PS3, Line 436: // notably, gauges may be non-zero and then reset to zero, so seeing that > Yea, I'll do that Done -- To view, visit http://gerrit.cloudera.org:8080/13580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8db3d082ae847eb1d83b9e4aee57d5e4bf13e1b5 Gerrit-Change-Number: 13580 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 16:36:14 +0000 Gerrit-HasComments: Yes
