Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 )
Change subject: [sentry] add require_db_privileges flag for ListTables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13657/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13657/2//COMMIT_MSG@23 PS2, Line 23: --has-db-privileges=true This isn't an apples-to-apples comparison, right? If the user has all db privileges, it doesn't matter whether --sentry_require_db_privileges_for_list_tables is true or not. Should probably set this to be the same value in both tests. Or replace --has-db-privileges with a --num-db-privileges configuration for the benchmark, where if d < FLAGS_num_db_privileges, grant the privilege on the db and if not, then grant the dummy privilege in ListTablesBenchmark. -- To view, visit http://gerrit.cloudera.org:8080/13657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a225932b22470d653d4b40678f32c2b5cb8329c Gerrit-Change-Number: 13657 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 15 Jun 2019 00:30:23 +0000 Gerrit-HasComments: Yes
