Yao Xu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13632 )

Change subject: KUDU-2823 Place tablet replicas based on range
......................................................................


Patch Set 7:

(2 comments)

Thanks Alexey, Todd for comments.

http://gerrit.cloudera.org:8080/#/c/13632/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13632/7//COMMIT_MSG@16
PS7, Line 16: Unfortunately, after we add some new tablet servers to the 
cluster,
            : creating a new tablet replica will prioritize the new tablet 
server for
            : placement according to the current placement policy
> Not related to this patch as is, but I'm curious: would running the
 > rebalancer after adding a new tablet servers into the system but
 > before creating new partitions could help?

Yes, this is helpful. But, in the case of a large amount of data, rebalancing 
will take a long time. I think the better way is that the newly created tablets 
are evenly distributed, and the previously existing tablets are balanced by 
rebalancer.


http://gerrit.cloudera.org:8080/#/c/13632/7//COMMIT_MSG@23
PS7, Line 23: So, I added a new placement policy. When creating a new tablet 
replica,
            : we prefer to select tablet server which a smaller number of tablet
            : replicas in the range
> Is it possible to generalize this policy, making it as an
 > additional dimension to the number of replicas at a tablet server?
 > That way we could make it a good default policy for placing new
 > replicas.

Yes, I think the way you said is more general than using range. Maybe we should 
specify the dimensions of the tablets when creating the partition and creating 
the table, instead of using the  range directly. What do you think?



--
To view, visit http://gerrit.cloudera.org:8080/13632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48a225e221eb42ef2f5489687e80a151d8dc1a42
Gerrit-Change-Number: 13632
Gerrit-PatchSet: 7
Gerrit-Owner: Yao Xu <oclarms....@gmail.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com>
Gerrit-Comment-Date: Tue, 18 Jun 2019 04:20:54 +0000
Gerrit-HasComments: Yes

Reply via email to