Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13666 )
Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/13666/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13666/2//COMMIT_MSG@16 PS2, Line 16: will only be prepared once > Currently I think we are limited to a single predicate per column, since Sc Thank you for the clarification. I looked into MaterializingIterator::Init() more closely and I don't see how we can get into the situation I was worried about. http://gerrit.cloudera.org:8080/#/c/13666/2/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/13666/2/src/kudu/tablet/cfile_set.cc@470 PS2, Line 470: prepared_iters_.clear(); > I don't think we'd gain much from that, since 'clear' doesn't actually shri Yep, doing it once in Init() is the best place, I agree. -- To view, visit http://gerrit.cloudera.org:8080/13666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I997fe832fdfa8d92fbbcb5d7c5bd4141e485b4f8 Gerrit-Change-Number: 13666 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 19 Jun 2019 00:14:55 +0000 Gerrit-HasComments: Yes
